damccorm commented on code in PR #32138:
URL: https://github.com/apache/beam/pull/32138#discussion_r1716642762
##########
sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/jvmverification/JvmVerification.java:
##########
@@ -70,6 +70,12 @@ public void verifyTestCodeIsCompiledWithJava21() throws
IOException {
}
// jvm
+ @Test
+ public void verifyRunningJVMVersionIs8() {
Review Comment:
Why do we need this one?
##########
sdks/java/testing/test-utils/src/test/java/org/apache/beam/sdk/testutils/jvmverification/JvmVerification.java:
##########
@@ -70,6 +70,12 @@ public void verifyTestCodeIsCompiledWithJava21() throws
IOException {
}
// jvm
+ @Test
+ public void verifyRunningJVMVersionIs8() {
Review Comment:
And should it replace the Is11 check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
