sjvanrossum commented on PR #32244: URL: https://github.com/apache/beam/pull/32244#issuecomment-2298729696
LGTM, thank you for picking this up! As a follow up, we could refactor the concrete versioned transforms into a heavily parametrized package-private abstract base class and subclass that for the provided versions of the Google Ads API at the current artifact version. It's still a chore since the SDK supplies no common super types or interfaces that can be used for type bounds, so the best we can do in more than a few places is something like `? extends Message`, but it makes it a bit easier to add multiple versions and gradually deprecate older releases throughout the year. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
