tvalentyn commented on code in PR #32082:
URL: https://github.com/apache/beam/pull/32082#discussion_r1725933227
##########
sdks/python/apache_beam/transforms/util.py:
##########
@@ -802,6 +802,20 @@ class BatchElements(PTransform):
corresponding to its contents. Each batch is emitted with a timestamp at
the end of their window.
+ When the max_batch_duration_secs arg is provided, a stateful implementation
+ of BatchElements is used to batch elements across bundles. This is most
+ impactful in streaming applications where many bundles only contain one
+ element. Larger max_batch_duration_secs values can reduce the throughput of
Review Comment:
```suggestion
element. Larger max_batch_duration_secs values `might` reduce the
throughput of
```
##########
sdks/python/apache_beam/transforms/util.py:
##########
@@ -802,6 +802,20 @@ class BatchElements(PTransform):
corresponding to its contents. Each batch is emitted with a timestamp at
the end of their window.
+ When the max_batch_duration_secs arg is provided, a stateful implementation
+ of BatchElements is used to batch elements across bundles. This is most
+ impactful in streaming applications where many bundles only contain one
+ element. Larger max_batch_duration_secs values can reduce the throughput of
+ the transform, while smaller values will improve the throughput but make it
Review Comment:
```suggestion
the transform, while smaller values `might` improve the throughput but
make it
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
