damccorm commented on PR #32285: URL: https://github.com/apache/beam/pull/32285#issuecomment-2305319812
> One could argue that this should be DRY'd into the `isHotKeyLoggingEnabled()` method instead of at each callsite, but given how much options code is generated, I'm not sure if it would be better. Yeah, that was my take - I think it would've been more work than it was work (given only 3 fairly rarely touched instances) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
