damccorm commented on code in PR #32033:
URL: https://github.com/apache/beam/pull/32033#discussion_r1729051875
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -1627,6 +1627,10 @@ def _add_argparse_args(cls, parser):
action='append',
Review Comment:
Looks like this is still failing format/lint checks - could you follow
https://cwiki.apache.org/confluence/display/BEAM/Python+Tips#PythonTips-LintandFormattingChecks
to fix?
##########
sdks/python/apache_beam/runners/portability/job_server_test.py:
##########
@@ -25,7 +25,8 @@
class JavaJarJobServerStub(JavaJarJobServer):
def java_arguments(
- self, job_port, artifact_port, expansion_port, artifacts_dir):
+ self,
+ job_port, artifact_port, expansion_port, artifacts_dir,
jar_cache_dir):
Review Comment:
I think this is causing `test_subprocess_cmd_and_endpoint` to fail since
paths don't pass in the cache dir. See for example
https://github.com/s21lee/beam/blob/e8322a7968845ba6c08c2b5fd91b676c99309dfa/sdks/python/apache_beam/runners/portability/job_server.py#L158
- I think we shouldn't add java_cache_dir as an arg here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
