damccorm commented on code in PR #32008:
URL: https://github.com/apache/beam/pull/32008#discussion_r1731477075
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java:
##########
@@ -876,6 +913,17 @@ public Read withHighPriority() {
return withSpannerConfig(config.withRpcPriority(RpcPriority.HIGH));
}
+ private SpannerSourceDef createSourceDef() {
+ SpannerSourceDef sourceDef;
+ if (getReadOperation().getQuery() != null) {
+ return SpannerQuerySourceDef.create(getSpannerConfig(),
getReadOperation().getQuery());
+ }
+
+ return SpannerTableSourceDef.create(
+ getSpannerConfig(), getReadOperation().getTable(),
getReadOperation().getColumns());
+ }
Review Comment:
My crappy markdown code didn't work
```suggestion
private SpannerSourceDef createSourceDef() {
if (getReadOperation().getQuery() != null) {
return SpannerQuerySourceDef.create(getSpannerConfig(),
getReadOperation().getQuery());
}
return SpannerTableSourceDef.create(
getSpannerConfig(), getReadOperation().getTable(),
getReadOperation().getColumns());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
