Polber commented on code in PR #32289:
URL: https://github.com/apache/beam/pull/32289#discussion_r1731941312
##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -351,8 +351,8 @@ class BigQueryWrapper(object):
HISTOGRAM_METRIC_LOGGER = MetricLogger()
- def __init__(self, client=None, temp_dataset_id=None, temp_table_ref=None):
- self.client = client or BigQueryWrapper._bigquery_client(PipelineOptions())
+ def __init__(self, client=None, temp_dataset_id=None, temp_table_ref=None,
project_id = None):
+ self.client = client or
BigQueryWrapper._bigquery_client(PipelineOptions(project = project_id))
Review Comment:
```suggestion
self.client = client or
BigQueryWrapper._bigquery_client(PipelineOptions())
```
##########
sdks/python/apache_beam/yaml/integration_tests.py:
##########
@@ -48,11 +48,11 @@ def gcs_temp_dir(bucket):
@contextlib.contextmanager
def temp_bigquery_table(project, prefix='yaml_bq_it_'):
- bigquery_client = BigQueryWrapper()
+ bigquery_client = BigQueryWrapper(project_id = "apache-beam-testing")
Review Comment:
```suggestion
bigquery_client = BigQueryWrapper()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
