tvalentyn commented on code in PR #32338:
URL: https://github.com/apache/beam/pull/32338#discussion_r1733400579
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinations.java:
##########
@@ -132,6 +132,10 @@ void setSideInputAccessorFromProcessContext(DoFn<?,
?>.ProcessContext context) {
/**
* Returns an object that represents at a high level which table is being
written to. May not
* return null.
+ *
+ * <p>Returned object is expected to be unique for different destination
tables involved over all
Review Comment:
Do users implement this method? If so, can we be more prescriptive:
For example:
```
Returned object must be unique for different destination tables involved
over all...
```
```
The method must return a unique object for different destination tables
involved over all...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
