baeminbo commented on issue #32251: URL: https://github.com/apache/beam/issues/32251#issuecomment-2323647986
I'm afraid that #32298 cannot fix this issue with a delimiter including a "repeated pattern". For example, the delimiter is "ABABC" and the text is "ABABABCD". The expected result is ["AB", "D"]. But, the actual result with the fix #32298 is ["ABABABCD", "D"]. The fix [considers](https://github.com/apache/beam/pull/32298/files#diff-638a856265a3f2e12f33c436603b99e8151a27072a07b05101fac77b15878129R459-R460) that the index 5 char "A" matches the index 0 char "A" in the delimiter. ``` In the fix: 01234567 ABABABCD ^ ABABC ``` But, it must match the index 2 char "A" in the delimiter. ``` Right match: 01234567 ABABABCD ^ ABABC ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
