arunpandianp commented on code in PR #32408:
URL: https://github.com/apache/beam/pull/32408#discussion_r1750531583
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java:
##########
@@ -152,7 +151,9 @@ public StreamingModeExecutionContext(
MetricsContainerRegistry<StreamingStepMetricsContainer>
metricsContainerRegistry,
DataflowExecutionStateTracker executionStateTracker,
StreamingModeExecutionStateRegistry executionStateRegistry,
- long sinkByteLimit) {
+ StreamingEnginePipelineConfigManager configManager,
Review Comment:
Good point about keeping the config consistent per bundle, fixed it.
> how about having this take a Supplier?
Extracted the public methods to a interface
`StreamingEnginePipelineConfigManager` and added a different implementation for
Appliance/Testing. I like specific interfaces compared to common interfaces
like Consumer/Supplier. The common interfaces makes it harder to find
references in IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
