lostluck commented on code in PR #32425:
URL: https://github.com/apache/beam/pull/32425#discussion_r1754885112
##########
sdks/go/test/integration/primitives/pardo.go:
##########
@@ -32,6 +33,9 @@ func init() {
register.Function3x2(asymJoinFn)
register.Function5x0(splitByName)
register.Function2x0(emitPipelineOptions)
+
beam.RegisterDoFn(reflect.TypeOf((*processElemBundleFinalizer)(nil)).Elem())
+
beam.RegisterDoFn(reflect.TypeOf((*finalizerInFinishBundle)(nil)).Elem())
+ beam.RegisterDoFn(reflect.TypeOf((*finalizerInAll)(nil)).Elem())
Review Comment:
Seems reasonable.
The big trick is we probably need to filter out this test from Docker mode
execution generally, and from the Python Portable runner.
We don't have a thing for filtering for the docker execution, but we do for
portable runner list in integration.go
Searching for `--- FAIL` finds the failure in the logs.
```
github.com/apache/beam/sdks/v2/go/test/integration/primitives.TestParDoBundleFinalizer.func1
not found. Register DoFns and functions with the the beam/register package.
--- FAIL: TestParDoBundleFinalizer/InFinishBundle (0.04s)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
