Abacn commented on PR #32414:
URL: https://github.com/apache/beam/pull/32414#issuecomment-2344042627

   This PR removed tests but the test result report shows test number remains 
the same as the main branch
   
   <img width="324" alt="image" 
src="https://github.com/user-attachments/assets/a6dd758d-7da6-4979-8d25-3b73c84e8c0b";>
   
   Later I realize `runners:prism:java:build` didn't add to 
   
   
https://github.com/apache/beam/blob/e8c6a8c3aec947e40b0cdbdbb3032114b790c5cf/build.gradle.kts#L235
   
   so the tests never exercised.
   
   I would suggest add `dependsOn("runners:prism:java:build")` to 
`tasks.register("javaPreCommit") {` so we are sure these codes can be safely 
removed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to