Polber commented on code in PR #32436: URL: https://github.com/apache/beam/pull/32436#discussion_r1755859736
########## sdks/python/apache_beam/yaml/examples/aggregation_using_sqlstatement.yaml: ########## @@ -0,0 +1,59 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: + - type: ReadFromCsv + name: ReadInputFile + config: + path: gs://apache-beam-samples/beam-yaml-blog/products.csv + delimiter: "," + - type: MapToFields + name: MapToFields + input: ReadInputFile + config: + language: sql + fields: + transaction_id: "transaction_id" + product_name: "product_name" + category: "category" + prices: "price" + - type: Sql + name: SqlCommand + config: + query: "select category, count(*) as cnt,sum(prices) as sum_prices, max(prices) as max_prices from PCOLLECTION group by category" + input: MapToFields + - type: WriteToCsv + name: WriteOutputFile + input: SqlCommand + config: + path: output + +# Expected: +# Row(category='Apparel', cnt=1, sum_prices=109.99, price=109.99) +# Row(category='Kitchen', cnt=1, sum_prices=29.99, price=29.99) +# Row(category='Electronics', cnt=3, sum_prices=369.97, price=249.99) Review Comment: ```suggestion # Row(category='Apparel', num_sold =1, revenue =109.99, max_price=109.99) # Row(category='Kitchen', num_sold =1, revenue =29.99, max_price=29.99) # Row(category='Electronics', num_sold =3, revenue =369.97, max_price=249.99) ``` ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sqlstatement.yaml: ########## @@ -0,0 +1,59 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: + - type: ReadFromCsv + name: ReadInputFile + config: + path: gs://apache-beam-samples/beam-yaml-blog/products.csv + delimiter: "," + - type: MapToFields + name: MapToFields + input: ReadInputFile + config: + language: sql + fields: + transaction_id: "transaction_id" + product_name: "product_name" + category: "category" + prices: "price" + - type: Sql + name: SqlCommand + config: + query: "select category, count(*) as cnt,sum(prices) as sum_prices, max(prices) as max_prices from PCOLLECTION group by category" + input: MapToFields + - type: WriteToCsv + name: WriteOutputFile + input: SqlCommand + config: + path: output Review Comment: ```suggestion path: output.csv ``` ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sqlstatement.yaml: ########## @@ -0,0 +1,59 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: + - type: ReadFromCsv + name: ReadInputFile + config: + path: gs://apache-beam-samples/beam-yaml-blog/products.csv + delimiter: "," + - type: MapToFields + name: MapToFields + input: ReadInputFile + config: + language: sql + fields: + transaction_id: "transaction_id" + product_name: "product_name" + category: "category" + prices: "price" + - type: Sql + name: SqlCommand + config: + query: "select category, count(*) as cnt,sum(prices) as sum_prices, max(prices) as max_prices from PCOLLECTION group by category" Review Comment: Let's use more descriptive column names that describe the intention ```suggestion query: "select category, count(*) as num_sold, sum(prices) as revenue, max(prices) as max_price from PCOLLECTION group by category" ``` ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sqlstatement.yaml: ########## @@ -0,0 +1,59 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". Review Comment: Update description here too ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sql.yaml: ########## @@ -0,0 +1,63 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". Review Comment: Please update description to describe intention of example ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sql.yaml: ########## @@ -0,0 +1,63 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: + - type: ReadFromCsv + name: ReadInputFile + config: + path: gs://apache-beam-samples/beam-yaml-blog/products.csv + delimiter: "," Review Comment: Is explicit comma delimiter needed? Should be default behavior Same for other example ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sqlstatement.yaml: ########## @@ -0,0 +1,59 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: + - type: ReadFromCsv + name: ReadInputFile + config: + path: gs://apache-beam-samples/beam-yaml-blog/products.csv + delimiter: "," + - type: MapToFields + name: MapToFields + input: ReadInputFile + config: + language: sql + fields: + transaction_id: "transaction_id" + product_name: "product_name" + category: "category" + prices: "price" Review Comment: This isn't performing any action ```suggestion ``` ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sqlstatement.yaml: ########## Review Comment: Let's rename file to `simple_sql_aggregation.yaml` ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sql.yaml: ########## @@ -0,0 +1,63 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: + - type: ReadFromCsv + name: ReadInputFile + config: + path: gs://apache-beam-samples/beam-yaml-blog/products.csv + delimiter: "," + - type: MapToFields + name: MapToFields + input: ReadInputFile + config: + language: sql + fields: + id: "transaction_id" + prod_name: "product_name" + category_name: "category" + price: "price" + - type: Combine + name: Combines + input: MapToFields + config: + language: sql + group_by: category_name + combine: + category_name: count + price: sum Review Comment: Let's rename for intention of aggregation ```suggestion num_sold: count revenue: sum ``` ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sql.yaml: ########## @@ -0,0 +1,63 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: + - type: ReadFromCsv + name: ReadInputFile + config: + path: gs://apache-beam-samples/beam-yaml-blog/products.csv + delimiter: "," + - type: MapToFields + name: MapToFields + input: ReadInputFile + config: + language: sql Review Comment: This is a generic name remapping so language isn't needed ```suggestion ``` ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sql.yaml: ########## @@ -0,0 +1,63 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: + - type: ReadFromCsv + name: ReadInputFile + config: + path: gs://apache-beam-samples/beam-yaml-blog/products.csv + delimiter: "," + - type: MapToFields + name: MapToFields + input: ReadInputFile + config: + language: sql + fields: + id: "transaction_id" + prod_name: "product_name" + category_name: "category" + price: "price" + - type: Combine + name: Combines + input: MapToFields + config: + language: sql + group_by: category_name + combine: + category_name: count + price: sum + - type: WriteToCsv + name: WriteOutputFile + input: Combines + config: + path: output + +# Expected: +# Row(category='Apparel', category_name0=1, price=109.99) +# Row(category='Kitchen', category_name0=1, price=29.99) +# Row(category='Electronics', category_name0=3, price=369.97) Review Comment: ```suggestion # Row(category_name='Apparel', num_sold =1, revenue =109.99) # Row(category_name='Kitchen', num_sold =1, revenue =29.99) # Row(category_name='Electronics', num_sold =3, revenue =369.97) ``` ########## sdks/python/apache_beam/yaml/examples/aggregation_using_sql.yaml: ########## Review Comment: Let's rename file to `simple_sql_combine.yaml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
