Abacn commented on code in PR #32442:
URL: https://github.com/apache/beam/pull/32442#discussion_r1759049172
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -1116,51 +1110,12 @@ public Write withMaxOutstandingBytes(long bytes) {
* always enabled on batch writes and limits the number of outstanding
requests to the Bigtable
* server.
*
- * <p>When enabled, will also set default {@link
#withThrottlingReportTargetMs} to 1 minute.
- * This enables runner react with increased latency in flush call due to
flow control.
- *
* <p>Does not modify this object.
*/
public Write withFlowControl(boolean enableFlowControl) {
- BigtableWriteOptions options = getBigtableWriteOptions();
- BigtableWriteOptions.Builder builder =
options.toBuilder().setFlowControl(enableFlowControl);
- if (enableFlowControl) {
- builder = builder.setThrottlingReportTargetMs(60_000);
- }
- return toBuilder().setBigtableWriteOptions(builder.build()).build();
- }
-
- /**
- * Returns a new {@link BigtableIO.Write} with client side latency based
throttling enabled.
- *
- * <p>Will also set {@link #withThrottlingReportTargetMs} to the same
value.
- */
- public Write withThrottlingTargetMs(int throttlingTargetMs) {
Review Comment:
I think I can and we should.
Only user actively set this method in their 2.59.0 pipeline will be
affected. Users do not explicitly set this method, and upgrade from <=2.58.0
are unaffected. For those indeed use this method in 2.59.0 they have good
reason to do so. We are removing a tested and functioning feature on request,
make it no-op or warning then user won't aware this feature is gone in the next
release.
In the past Beam has an "Experimental" annotation but voted to remove them
(#26490). Now "new code is changeable/evolving by default" (see discussion link
in that PR) especially true for a new API in single version not enabled by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
