ahmedabu98 commented on code in PR #31608:
URL: https://github.com/apache/beam/pull/31608#discussion_r1761012385
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java:
##########
@@ -1543,7 +1543,6 @@ public PDone expand(PCollection<T> input) {
new PreparePubsubWriteDoFn<>(
getFormatFn(),
topicFunction,
- getNeedsOrderingKey(),
Review Comment:
Agreed that the wording could be better, but this option already exists with
the same name for Pubsub read. This follows a pattern with other Pubsub message
components as well:
https://github.com/apache/beam/blob/12974595cd0405942ab8b90ba6475c7eae0d4769/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIO.java#L853-L857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
