Abacn commented on code in PR #32360:
URL: https://github.com/apache/beam/pull/32360#discussion_r1761144791
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySourceDef.java:
##########
@@ -42,15 +40,15 @@ interface BigQuerySourceDef extends Serializable {
<T> BigQuerySourceBase<T> toSource(
String stepUuid,
Coder<T> coder,
- SerializableFunction<TableSchema, AvroSource.DatumReaderFactory<T>>
readerFactory,
+ BigQueryReaderFactory<T> readerFactory,
boolean useAvroLogicalTypes);
/**
- * Extract the Beam {@link Schema} corresponding to this source.
+ * Extract the {@link TableSchema} corresponding to this source.
*
* @param bqOptions BigQueryOptions
- * @return Beam schema of the source
+ * @return table schema of the source
* @throws BigQuerySchemaRetrievalException if schema retrieval fails
*/
- Schema getBeamSchema(BigQueryOptions bqOptions);
+ TableSchema getTableSchema(BigQueryOptions bqOptions);
Review Comment:
There was proposal to make Beam Schema uniform in future Beam versions
(3.x), unfortunately BigQueryIO is the biggest IO that do not follow this (and
has its own TableSchema that does not implements Serializable). I would suggest
keep "getBeamSchema". We can have "getTableSchema" as addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
