jrmccluskey commented on code in PR #32471:
URL: https://github.com/apache/beam/pull/32471#discussion_r1761774343
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient_test.py:
##########
@@ -998,12 +998,12 @@ def
test_interpreter_version_check_passes_with_experiment(self):
@mock.patch(
'apache_beam.runners.dataflow.internal.apiclient.sys.version_info',
- (3, 8, 2))
Review Comment:
If that's actually how we want to go about it then that's fine, but I'm of
the opinion that if we're not testing things we're better off moving forward
with removing support. I can put 3.8 back on that list for now if that's
preferred and we can move this discussion to a later PR actually removing 3.8
support from beam proper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
