amaliujia commented on a change in pull request #12595:
URL: https://github.com/apache/beam/pull/12595#discussion_r478837407
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##########
@@ -978,7 +978,7 @@ private RexNode
convertResolvedStructFieldAccessInternal(RexNode referencedExpr,
return rexBuilder().makeFieldAccess(referencedExpr, fieldIdx);
}
- private RexBuilder rexBuilder() {
+ public RexBuilder rexBuilder() {
Review comment:
I am thinking this is not needed. In every Rel converter they can get
RexBuilder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
