damccorm commented on code in PR #32493:
URL: https://github.com/apache/beam/pull/32493#discussion_r1765448022
##########
.github/workflows/beam_PostCommit_XVR_GoUsingJava_Dataflow.yml:
##########
@@ -84,8 +85,9 @@ jobs:
USER: github-actions
CLOUDSDK_CONFIG: ${{ env.KUBELET_GCLOUD_CONFIG_PATH}}
uses: ./.github/actions/gradle-command-self-hosted-action
- with:
- gradle-command:
:runners:google-cloud-dataflow-java:validatesCrossLanguageRunnerGoUsingJava
+ # TODO(https://github.com/apache/beam/issues/32492): re-enable the
suite.
+ # with:
+ # gradle-command:
:runners:google-cloud-dataflow-java:validatesCrossLanguageRunnerGoUsingJava
Review Comment:
Lol, the script doesn't like that either. We probably should just insert
some logic in
https://github.com/apache/beam/blob/eb8639b013e9d820a253970ed03ac0e7cfc6e13e/.github/build.gradle#L41
to allow disabling.
Maybe we could just have a string check that we have something like
`gha-check-ignore` defined somewhere in the file contents? Or we could have a
separate file like `release/trigger_all_disabled_workflows.json` and check that
you're either triggering on that OR on `release/trigger_all_tests.json`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
