shunping commented on PR #32286: URL: https://github.com/apache/beam/pull/32286#issuecomment-2361869783
Thanks for contributing to Beam, @reeba212! I see there is some lint problem you will need to fix in your code: https://github.com/apache/beam/actions/runs/10944933393/job/30387980829?pr=32286 Then, I also see the errors on when import `feast` package. Currently `feast` is not on our dependency list (i.e. setup.py), that's why those tests fail. ``` target/.tox-py310-cloud/py310-cloud/lib/python3.10/site-packages/apache_beam/yaml/yaml_enrichment.py:22: in <module> from apache_beam.transforms.enrichment_handlers.feast_feature_store import FeastFeatureStoreEnrichmentHandler _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ # # Licensed to the Apache Software Foundation (ASF) under one or more # contributor license agreements. See the NOTICE file distributed with # this work for additional information regarding copyright ownership. # The ASF licenses this file to You under the Apache License, Version 2.0 # (the "License"); you may not use this file except in compliance with # the License. You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. # import logging import tempfile from pathlib import Path from typing import Any from typing import Callable from typing import List from typing import Mapping from typing import Optional import apache_beam as beam from apache_beam.io.filesystems import FileSystems from apache_beam.transforms.enrichment import EnrichmentSourceHandler from apache_beam.transforms.enrichment_handlers.utils import ExceptionLevel > from feast import FeatureStore E ModuleNotFoundError: No module named 'feast' target/.tox-py310-cloud/py310-cloud/lib/python3.10/site-packages/apache_beam/transforms/enrichment_handlers/feast_feature_store.py:30: ModuleNotFoundError ``` @Polber, what's the plan for supporting the enrichment transform? To make tests green, we have a few options. For example: - including `feast` as the standard dependency of beam, - decorating yaml tests with "@pytest.mark.uses_feast", or - totally ignoring the feast handler. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
