scwhittle commented on code in PR #32503:
URL: https://github.com/apache/beam/pull/32503#discussion_r1768253805
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDispatcherClient.java:
##########
@@ -62,31 +67,58 @@ public class GrpcDispatcherClient {
@GuardedBy("this")
private final Random rand;
+ private final WindmillStubFactoryFactory windmillStubFactoryFactory;
+
+ private final AtomicReference<WindmillStubFactory> windmillStubFactory = new
AtomicReference<>();
+
+ private final AtomicBoolean useIsolatedChannels = new AtomicBoolean();
+ private final boolean reactToIsolatedChannelsJobSetting;
+
private GrpcDispatcherClient(
- WindmillStubFactory windmillStubFactory,
+ DataflowWorkerHarnessOptions options,
+ WindmillStubFactoryFactory windmillStubFactoryFactory,
DispatcherStubs initialDispatcherStubs,
Random rand) {
- this.windmillStubFactory = windmillStubFactory;
+ this.windmillStubFactoryFactory = windmillStubFactoryFactory;
+ if (DataflowRunner.hasExperiment(
+ options, STREAMING_ENGINE_USE_JOB_SETTINGS_FOR_ISOLATED_CHANNELS)) {
Review Comment:
Discussed, leaving as is and will remove once safe. Defaulting to on will
let us cleanup eventually and have released sdks use preferred behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
