shunping commented on code in PR #32518:
URL: https://github.com/apache/beam/pull/32518#discussion_r1769357960
##########
sdks/python/apache_beam/options/pipeline_options_test.py:
##########
@@ -718,6 +719,7 @@ def test_validation_good_stg_good_temp(self):
'--staging_location=gs://beam/stg',
'--temp_location=gs://beam/tmp'
])
+ options.view_as(TestOptions).dry_run = True
Review Comment:
Unfortunately, mock does not work when tests are run in our GitHub actions.
Because we don't have google-cloud-storage installed for these unit tests on
pipeline. As a result, mocking on 'apache_beam.io.gcp.gcsio' will give an
error, and I don't want to have a condition inside the test to say "if we can
load the package, we will do the mock; otherwise we skip it".
I am open to any suggestions though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
