twosom commented on PR #32470: URL: https://github.com/apache/beam/pull/32470#issuecomment-2370925463
> Thanks for the contribution. The added PTransform and DoFn pretty much duplicated the existing one. I would suggest adjust the current ~Write transform~ and WriteFn for this feature. This avoids branches and more independent transform/DoFn to maintain. Should be straightforward to do so. > > I see, there was concern of breaking change, Write originally is not a generic but WriteDynamics transform is a generic. We can make Write to return a WriteDynamics<byte[]> with fixed topicFn and identity payloadFn. @Abacn Thanks for your comment. I'll make the improvements you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
