claudevdm opened a new pull request, #32574: URL: https://github.com/apache/beam/pull/32574
Create and use ParentAwareThread in Pardo#with_exception_handling(timeout) - ParDo#with_exception_handling(timeout) executes the DoFn in a new thread [1] - Incrimenting a counter invokes tries to access the state sampler that was declared in the main thread local storage from the child thread [2] - Since the child thread does not have access to the state sampler from the main thread the get_current_tracker method fails silently [3] and the counter isnt actually incremented This change - Creates a new ParentAwareThread class that stores the ID of its parent thread - Refactors state samplers to be stored in a non thread-local dictionary where each thread's state sampler is keyed by thread id - When a ParentAwareThread increments a counter it retrieves the state sampler set by its parent thread [1] https://github.com/apache/beam/blob/1eddbdca4c5efe4bfccc11af29624f9689ea2997/sdks/python/apache_beam/transforms/core.py#L2599 [2] https://github.com/apache/beam/blob/1eddbdca4c5efe4bfccc11af29624f9689ea2997/sdks/python/apache_beam/runners/worker/statesampler.py#L43 [3] https://github.com/apache/beam/blob/1eddbdca4c5efe4bfccc11af29624f9689ea2997/sdks/python/apache_beam/runners/worker/statesampler.py#L54 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
