dedocibula commented on code in PR #32510:
URL: https://github.com/apache/beam/pull/32510#discussion_r1779806854


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/PartitionMetadataDao.java:
##########
@@ -82,9 +82,7 @@ public class PartitionMetadataDao {
   public boolean tableExists() {
     final String checkTableExistsStmt =
         "SELECT t.table_name FROM information_schema.tables AS t "
-            + "WHERE t.table_catalog = '' AND "
-            + "t.table_schema = '' AND "
-            + "t.table_name = '"
+            + "WHERE t.table_name = '"

Review Comment:
   Instead of removing the filtering altogether can you fork to code depending 
on `this.isPostgres()` (see `getPartition` below for an example)?
   
   For GoogleSQL (else) you can leave the query as is.
   For Postgres simply remove t.table_catalog and only keep t.table_schema = 
"public"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to