dedocibula commented on code in PR #32689:
URL: https://github.com/apache/beam/pull/32689#discussion_r1793929250
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/PartitionMetadataDao.java:
##########
@@ -96,6 +96,30 @@ public boolean tableExists() {
}
}
+ /**
+ * Finds all indexes for the metadata table.
+ *
+ * @return a list of index names for the metadata table.
+ */
+ public List<String> findAllTableIndexes() {
+ final String indexesStmt =
Review Comment:
Sg, a small nit would be to add table_schema filtering - '' for GoogleSQL
and 'public' for Postgres. That way this query will behave expectedly for dbs
with named schemas (which we currently don't support)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
