johnjcasey commented on code in PR #32722:
URL: https://github.com/apache/beam/pull/32722#discussion_r1795560530
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1453,6 +1455,24 @@ public Read<K, V> withConsumerPollingTimeout(long
duration) {
return toBuilder().setConsumerPollingTimeout(duration).build();
}
+ /**
+ * Creates and sets the Application Default Credentials for a Kafka
consumer. This allows the
+ * consumer to be authenticated with a Google Kafka Server using OAuth.
+ */
+ public Read<K, V> withApplicationDefaultCredentials() {
Review Comment:
I want to rename this method to make it clear its GCP focused. Maybe
withGCPApplicationDefaultCredentials()?
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -3362,6 +3382,23 @@ public Write<K, V>
withBadRecordErrorHandler(ErrorHandler<BadRecord, ?> badRecor
getWriteRecordsTransform().withBadRecordErrorHandler(badRecordErrorHandler));
}
+ /**
+ * Creates and sets the Application Default Credentials for a Kafka
producer. This allows the
+ * consumer to be authenticated with a Google Kafka Server using OAuth.
+ */
+ public Write<K, V> withApplicationDefaultCredentials() {
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
