Abacn commented on code in PR #32744:
URL: https://github.com/apache/beam/pull/32744#discussion_r1795976010
##########
sdks/python/scripts/run_snapshot_publish.sh:
##########
@@ -30,8 +30,10 @@ DEP_SNAPSHOT_FILE_NAME="beam-py-requirements-$time.txt"
# and located under Gradle build directory.
cd $WORKSPACE/sdks/python/build
-# Rename the file to be apache-beam-{VERSION}-{datetime}.tar.gz
-for file in "apache-beam-$VERSION*.tar.gz"; do
+# Rename the file to be apache_beam-{VERSION}-{datetime}.tar.gz
+# Notice that the distribution name of beam has been normalized as
"apache_beam"
+# since setuptools 69.3.0.
+for file in "apache_beam-$VERSION*.tar.gz"; do
Review Comment:
shall we use `apache?beam-$VERSION*` so both are supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
