m-trieu opened a new pull request, #32774:
URL: https://github.com/apache/beam/pull/32774
Start and closing Windmill streams are currently via `halfClose()` and on
stream creation. Implementations were previously created and returned in a
"started" state usually after the stream has already sent the initial headers
to open the connection to the backend servers.
Starting in the current state prevents us from being able to start the
stream "lazily". And closing allows other blocking stream operations to
prevent streams from being able to be closed (stalling at times up to 10-20
minutes).
- Add start() flexibility to the WindmillStream API by allowing external
callers to start the stream themselves.
- Add shutdown() capability to allow the stream to receive a shutdown
signal, that is idempotent and does not block (or is blocked by) other blocking
stream operations.
This is especially important in direct path mode where the user worker
manages the fan out to the backend.
in terms of implementation, similar to WindmillStream.shutdown(),
WindmillStream.start()'s behavior will only execute once during the lifetime of
the WindmillStream object. Subsequent calls to start() and shutdown() will do
nothing.
R: @arunpandianp @scwhittle
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
