tvalentyn commented on code in PR #32773:
URL: https://github.com/apache/beam/pull/32773#discussion_r1800175195


##########
sdks/python/pyproject.toml:
##########
@@ -21,7 +21,7 @@
 requires = [
     "setuptools",
     "wheel>=0.36.0",
-    "grpcio-tools==1.62.1",

Review Comment:
   This affects the version of grpc compiler used to generate python stubs for 
grpc protos, and we cannot use the latest version due to incompatibilites.
   
   ```
   RuntimeError: The grpc package installed is at version 1.65.5, but the 
generated code in org/apache/beam/model/pipeline/v1/metrics_pb2_grpc.py depends 
on grpcio>=1.66.2. Please upgrade your grpc module to grpcio>=1.66.2 or 
downgrade your generated code using grpcio-tools<=1.65.5.
   ```
   
   I would keep it as is, we MIGHT have to bump this up due to protobuf upgrade 
but if we don't have to, I think we can keep as is.
   
   We definitely cannot upgrade to grpcio>=1.66.2 while 
https://github.com/grpc/grpc/issues/37710 is unresolved
   
   cc: @jrmccluskey 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to