tvalentyn commented on code in PR #32643:
URL: https://github.com/apache/beam/pull/32643#discussion_r1800201901


##########
sdks/python/setup.py:
##########
@@ -155,7 +155,7 @@ def cythonize(*args, **kwargs):
 # Exclude 1.5.0 and 1.5.1 because of
 # https://github.com/pandas-dev/pandas/issues/45725
 dataframe_dependency = [
-    'pandas>=1.4.3,!=1.5.0,!=1.5.1,<2.3;python_version>="3.8"',
+    'pandas>=1.4.3,!=1.5.0,!=1.5.1,<2.3;python_version>="3.9"',

Review Comment:
   conditions like this make sense when we install different dependency 
versions depending on Python version, for example, pandas 1.x for Python 3.7, 
and Pandas 2.x for all other versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to