scwhittle commented on code in PR #32779:
URL: https://github.com/apache/beam/pull/32779#discussion_r1801028495
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/BoundedQueueExecutor.java:
##########
@@ -99,6 +102,7 @@ protected void afterExecute(Runnable r, Throwable t) {
// Before adding a Work to the queue, check that there are enough bytes of
space or no other
// outstanding elements of work.
public void execute(Runnable work, long workBytes) {
+ numQueued.incrementAndGet();
Review Comment:
I'm not sure this is going to show what you think. We generally don't have
many things calling execute(), ie a single thread in SE which is servicing
GetWorkStream. So this may just show 1 thing queued while that call to
execute() is blocked waiting for the monitor below.
It won't show the X elements behind that execute call that are still
buffered on the GetWorkStream etc.
If we're not showing the full # of keys just the # of callers, I think that
the status page value isn't much more than if we already show that the current
executing is greater than or equal to the limit as that will trigger blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
