damccorm commented on code in PR #32780:
URL: https://github.com/apache/beam/pull/32780#discussion_r1801717224
##########
sdks/python/apache_beam/transforms/enrichment_handlers/bigquery.py:
##########
@@ -194,14 +202,16 @@ def __call__(self, request: Union[beam.Row,
List[beam.Row]], *args, **kwargs):
"Make sure the values passed in `fields` are the "
"keys in the input `beam.Row`." + str(e))
values.extend(current_values)
- requests_map.update((val, req) for val in current_values)
+ requests_map.update(
+ (self.create_row_key(req), req) for val in current_values)
Review Comment:
Is this now just inserting `(self.create_row_key(req), req)` into the map
repeatedly? It doesn't seem like we need the `for val in current_values` anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
