Abacn commented on code in PR #32841:
URL: https://github.com/apache/beam/pull/32841#discussion_r1805708499
##########
release/src/main/groovy/TestScripts.groovy:
##########
@@ -209,16 +220,17 @@ class TestScripts {
</profile>
</profiles>
</settings>
- """
- def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B"
- String path = System.getenv("PATH");
- // Set the path on jenkins executors to use a recent maven
- // MAVEN_HOME is not set on some executors, so default to 3.5.2
- String maven_home = System.getenv("MAVEN_HOME") ?:
'/home/jenkins/tools/maven/apache-maven-3.5.4'
- println "Using maven ${maven_home}"
- def mvnPath = "${maven_home}/bin"
- def setPath = "export PATH=\"${mvnPath}:${path}\" && "
- return _execute(setPath + cmd)
+ """
+ }
+ def cmd = "mvn ${args} -s ${settings.absolutePath} -Ptestrel -B"
Review Comment:
Sorry later on I found my initial investigation in
https://github.com/apache/beam/issues/32824#issuecomment-2419679190 was wrong.
In particular, the test workflow 8 tasks in parallel, each spin up an
individual maven local repository, and delete after finish. So there isn't
exist scenario that bad local repository cached can interfere the next run.
Using `-U` tag will cause the workflow making more requests to maven
snapshot repository, which is known to be less stable in terms of availability,
and I am afraid it would worsen rate limiting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
