m-trieu commented on code in PR #32774:
URL: https://github.com/apache/beam/pull/32774#discussion_r1806045420
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcCommitWorkStream.java:
##########
@@ -204,14 +224,14 @@ private void flushInternal(Map<Long, PendingRequest>
requests) {
}
}
- private void issueSingleRequest(final long id, PendingRequest
pendingRequest) {
+ private void issueSingleRequest(long id, PendingRequest pendingRequest) {
StreamingCommitWorkRequest.Builder requestBuilder =
StreamingCommitWorkRequest.newBuilder();
requestBuilder
.addCommitChunkBuilder()
- .setComputationId(pendingRequest.computation)
+ .setComputationId(pendingRequest.computationId())
.setRequestId(id)
- .setShardingKey(pendingRequest.request.getShardingKey())
- .setSerializedWorkItemCommit(pendingRequest.request.toByteString());
+ .setShardingKey(pendingRequest.shardingKey())
+ .setSerializedWorkItemCommit(pendingRequest.serializedCommit());
StreamingCommitWorkRequest chunk = requestBuilder.build();
synchronized (this) {
pending.put(id, pendingRequest);
Review Comment:
it will be removed and drained
pending just stores information so that when we get a response we can match
it to the pending request
if the stream gets shutdown all of pending is now invalid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
