DanielMorales9 commented on code in PR #32879:
URL: https://github.com/apache/beam/pull/32879#discussion_r1807930482
##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/RecordWriterManagerTest.java:
##########
@@ -269,6 +271,25 @@ public void testRequireClosingBeforeFetchingDataFiles() {
assertThrows(IllegalStateException.class,
writerManager::getSerializableDataFiles);
}
+ /** DataFile doesn't implement a .equals() method. Check equality manually.
*/
+ private static void checkDataFileEquality(DataFile d1, DataFile d2) {
Review Comment:
nit: `assertDataFileEquals` perhaps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
