scwhittle commented on code in PR #32775:
URL: https://github.com/apache/beam/pull/32775#discussion_r1808281968
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDirectGetWorkStream.java:
##########
@@ -300,49 +290,57 @@ private void executeSafely(Runnable runnable) {
* extensions.
*/
@ThreadSafe
- @AutoValue
- abstract static class GetWorkBudgetTracker {
-
- private static GetWorkBudgetTracker create(GetWorkBudget
initialMaxGetWorkBudget) {
- return new AutoValue_GrpcDirectGetWorkStream_GetWorkBudgetTracker(
- new AtomicReference<>(initialMaxGetWorkBudget),
- new AtomicLong(),
- new AtomicLong(),
- new AtomicLong(),
- new AtomicLong());
- }
+ private static final class GetWorkBudgetTracker {
+
+ @GuardedBy("GetWorkBudgetTracker.this")
Review Comment:
you can just use "this"
https://javadoc.io/doc/com.google.code.findbugs/annotations/latest/javax/annotation/concurrent/GuardedBy.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
