scwhittle commented on code in PR #32893:
URL: https://github.com/apache/beam/pull/32893#discussion_r1812272640


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/WindmillMap.java:
##########
@@ -142,6 +142,7 @@ protected Windmill.WorkItemCommitRequest 
persistDirectly(WindmillStateCache.ForK
           .setTag(keyBytes)
           .setStateFamily(stateFamily)
           .getValueBuilder()

Review Comment:
   nit: I think you can fix instead by removing the valuebuilder and 
settimestamp and it's simpler code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to