m-trieu commented on code in PR #32774:
URL: https://github.com/apache/beam/pull/32774#discussion_r1813347547
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcCommitWorkStream.java:
##########
@@ -283,21 +313,97 @@ private void issueMultiChunkRequest(final long id,
PendingRequest pendingRequest
}
}
- private static class PendingRequest {
+ private boolean shouldCancelRequest(long id, PendingRequest request) {
Review Comment:
changed to isPrepareForSendFailed
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcCommitWorkStream.java:
##########
@@ -283,21 +313,97 @@ private void issueMultiChunkRequest(final long id,
PendingRequest pendingRequest
}
}
- private static class PendingRequest {
+ private boolean shouldCancelRequest(long id, PendingRequest request) {
Review Comment:
added comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
