kennknowles commented on code in PR #5493: URL: https://github.com/apache/beam/pull/5493#discussion_r1813421537
########## runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobInvoker.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.flink; + +import com.google.common.util.concurrent.ListeningExecutorService; +import com.google.protobuf.Struct; +import java.io.IOException; +import java.util.UUID; +import javax.annotation.Nullable; +import org.apache.beam.model.pipeline.v1.RunnerApi; +import org.apache.beam.runners.core.construction.PipelineOptionsTranslation; +import org.apache.beam.runners.fnexecution.jobsubmission.JobInvocation; +import org.apache.beam.runners.fnexecution.jobsubmission.JobInvoker; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Job Invoker for the {@link FlinkRunner}. + */ +public class FlinkJobInvoker implements JobInvoker { + private static final Logger LOG = LoggerFactory.getLogger(FlinkJobInvoker.class); + + public static FlinkJobInvoker create(ListeningExecutorService executorService) { + return new FlinkJobInvoker(executorService); + } + + private final ListeningExecutorService executorService; + + private FlinkJobInvoker(ListeningExecutorService executorService) { + this.executorService = executorService; + } + + @Override + public JobInvocation invoke( + RunnerApi.Pipeline pipeline, Struct options, @Nullable String artifactToken) + throws IOException { + // TODO: How to make Java/Python agree on names of keys and their values? + LOG.trace("Parsing pipeline options"); + FlinkPipelineOptions flinkOptions = PipelineOptionsTranslation.fromProto(options) + .as(FlinkPipelineOptions.class); + + String invocationId = String.format( + "%s_%s", flinkOptions.getJobName(), UUID.randomUUID().toString()); + LOG.debug("Invoking job {}", invocationId); + + // Set Flink Master to [auto] if no option was specified. + if (flinkOptions.getFlinkMaster() == null) { + flinkOptions.setFlinkMaster("[auto]"); + } + + flinkOptions.setRunner(null); Review Comment: I came across this today as well. Do you know? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
