Abacn commented on code in PR #32909:
URL: https://github.com/apache/beam/pull/32909#discussion_r1815592649
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/RpcQos.java:
##########
@@ -200,11 +200,10 @@ interface RpcWriteAttempt extends RpcAttempt {
* provided {@code instant}.
*
* @param instant The intended start time of the next rpc
- * @param <T> The type which will be sent in the request
* @param <ElementT> The {@link Element} type which the returned buffer
will contain
* @return a new {@link FlushBuffer} which queued messages can be staged
to before final flush
*/
- <T, ElementT extends Element<T>> FlushBuffer<ElementT>
newFlushBuffer(Instant instant);
+ <ElementT extends Element<?>> FlushBuffer<ElementT> newFlushBuffer(Instant
instant);
Review Comment:
Admit that it is a compile time regression. Not a matter at runtime as
generics are erased.
RpcWriteAttempt / RpcWriteAttempt.FlushBuffer / RpcWriteAttempt.Element are
package private visible interfaces so user won't feel it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
