ahmedabu98 commented on code in PR #32940:
URL: https://github.com/apache/beam/pull/32940#discussion_r1817317999
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/RecordWriterManager.java:
##########
@@ -91,6 +91,7 @@ class DestinationState {
final Cache<PartitionKey, RecordWriter> writers;
private final List<SerializableDataFile> dataFiles = Lists.newArrayList();
@VisibleForTesting final Map<PartitionKey, Integer> writerCounts =
Maps.newHashMap();
+ private final List<Exception> exceptions = Lists.newArrayList();
Review Comment:
No, thread safety isn't a concern here because a RecordWriterManager
instance isn't shared between threads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
