reuvenlax commented on code in PR #32805:
URL: https://github.com/apache/beam/pull/32805#discussion_r1819451319
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiLoads.java:
##########
@@ -354,25 +355,34 @@ public WriteResult expandUntriggered(
rowUpdateFn,
badRecordRouter));
+ PCollection<KV<DestinationT, StorageApiWritePayload>>
successfulConvertedRows =
+ convertMessagesResult.get(successfulConvertedRowsTag);
+
+ if (numShards > 0) {
Review Comment:
I'm worried about this being subtly backwards incompatible. There may well
be users who set this parameter today in batch (e.g. because they simply reuse
their streaming code in batch) and will suddenly find their job much slower
after upgrading Beam versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
