iemejia commented on a change in pull request #12630:
URL: https://github.com/apache/beam/pull/12630#discussion_r476757936
##########
File path:
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOTest.java
##########
@@ -1807,9 +1809,13 @@ void shutdown() {
}
}
+ /**
+ * Mock records with a different schema to test deserializing evolved schema
using
Review comment:
It seems this broke the checkstyle validations (First paragraph should
finish with period (.). That's the reason why the precommit tests are not
passing.
##########
File path:
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOTest.java
##########
@@ -1807,9 +1809,13 @@ void shutdown() {
}
}
+ /**
+ * Mock records with a different schema to test deserializing evolved schema
using
+ * ConfluentSchemaRegistryDeserializerProvider
+ */
private abstract static class BaseAvroSerializableFunction
implements SerializableFunction<Integer, byte[]> {
- static transient Serializer<AvroGeneratedUser> serializer = null;
+ static transient Serializer<GenericRecord> serializer = null;
Review comment:
We should not change this function because it is used by other tests,
maybe we should create a new one that produces GenericRecords and we can
parametrize to produce schema specific records.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
