SamLeurink commented on issue #32468:
URL: https://github.com/apache/beam/issues/32468#issuecomment-2451755033
@twosom
Hi,
The PR is looking really good. Thank you for implementing this feature!
One thing I would maybe change is the parameter `additionalTopics`. If this
is incorporated in the parameter `topic`
it would add the possibility to place Iterables such as lists in it's place.
For example:
```java
List<String> topicList = Stream.of("topic1", "topic2", "topic3")
.collect(Collectors.toList());
pipeline.apply(
MqttIO.readWithMetadata()
.withConnectionConfiguration(
MqttIO.ConnectionConfiguration.create(
"tcp://host:1883",
topicList))
);
```
It should only be a small change in the `create` method.
Let me know if it's possible to implement or if it's conflicting in any way!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
