m-trieu commented on code in PR #32774:
URL: https://github.com/apache/beam/pull/32774#discussion_r1831879138


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/observers/DirectStreamObserver.java:
##########
@@ -139,4 +166,29 @@ public void onCompleted() {
       outboundObserver.onCompleted();
     }
   }
+
+  @Override
+  public void terminate(Throwable terminationException) {
+    // Free the blocked threads in onNext().
+    isReadyNotifier.forceTermination();
+    try {
+      onError(terminationException);
+    } catch (RuntimeException e) {
+      // If onError or onComplete was previously called, this will throw.

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to