arunpandianp opened a new pull request, #33037: URL: https://github.com/apache/beam/pull/33037
This fixes an exception during drain on jobs with GlobalWindows + AllowedLateness > 24h + @OnExpiredWindows callback Before the fix, the computed state cleanup timer timestamp can be > BoundedWindow.TIMESTAMP_MAX_VALUE. Before the timer is committed, logic in https://github.com/apache/beam/blob/81f35ab62298a2ec9fadeded82461b363b6401db/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimeUtils.java caps the timestamp to BoundedWindow.TIMESTAMP_MAX_VALUE When the timer fires at TIMESTAMP_MAX_VALUE, the check in SimpleParDoFn.java that compares timer timestamp with `earliestAllowableCleanupTime()` fails. https://github.com/apache/beam/blob/e598df7e3ccb4543d02e7d4b9c524d3f471228cd/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java#L397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
