tvalentyn commented on code in PR #33058:
URL: https://github.com/apache/beam/pull/33058#discussion_r1834898317
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -428,7 +428,7 @@
"# Choose a machine type compatible with GPU type\n",
"options.view_as(WorkerOptions).machine_type = \"n1-standard-4\"\n",
"\n",
- "options.view_as(WorkerOptions).worker_harness_container_image =
'%s:latest' % CONTAINER_LOCATION"
+ "options.view_as(WorkerOptions).worker_harness_container_image =
CONTAINER_LOCATION"
Review Comment:
```suggestion
"options.view_as(WorkerOptions).sdk_container_image =
CONTAINER_IMAGE"
```
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -396,7 +396,7 @@
"options = PipelineOptions()\n",
"\n",
"BUCKET_NAME = '<BUCKET_NAME>' # Replace with your bucket name.\n",
- "CONTAINER_LOCATION = '<REPOSITORY_NAME>' # Replace with your
container location (<your_gar_repository> from the previous step)\n",
+ "CONTAINER_LOCATION = '<REPOSITORY_NAME>' # Replace with your
container location (<REPOSITORY_NAME>:<TAG> from the previous step)\n",
Review Comment:
```suggestion
"CONTAINER_IMAGE = '<REPOSITORY_NAME>:<TAG>' # Replace with the
image repository and tag from the previous step.\n",
```
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -396,7 +396,7 @@
"options = PipelineOptions()\n",
"\n",
"BUCKET_NAME = '<BUCKET_NAME>' # Replace with your bucket name.\n",
- "CONTAINER_LOCATION = '<REPOSITORY_NAME>' # Replace with your
container location (<your_gar_repository> from the previous step)\n",
+ "CONTAINER_LOCATION = '<REPOSITORY_NAME>' # Replace with your
container location (<REPOSITORY_NAME>:<TAG> from the previous step)\n",
Review Comment:
One option is to also define this earlier.
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -352,11 +352,11 @@
"\n",
"1. In the sidebar, click **Files** to open the **Files** pane.\n",
"2. In an environment with Docker installed, download the file
**VllmDockerfile** file to an empty folder.\n",
- "3. Run the following commands. Replace `<REPOSITORY_NAME>` with a
valid [Artifact
Registry](https://cloud.google.com/artifact-registry/docs/overview)
repository.\n",
+ "3. Run the following commands. Replace `<REPOSITORY_NAME>:<TAG>` with
a valid [Artifact
Registry](https://cloud.google.com/artifact-registry/docs/overview) repository
and tag.\n",
Review Comment:
```suggestion
"3. Run the following commands. Replace `<REPOSITORY_NAME>:<TAG>`
with a valid [Artifact
Registry](https://cloud.google.com/artifact-registry/docs/overview) repository
and tag.\n",
```
##########
examples/notebooks/beam-ml/run_inference_vllm.ipynb:
##########
@@ -373,7 +373,7 @@
"First, define the pipeline options that you want to use to launch the
Dataflow job. Before running the next cell, replace the following variables:\n",
"\n",
"- `<BUCKET_NAME>`: the name of a valid [Google Cloud
Storage](https://cloud.google.com/storage?e=48754805&hl=en) bucket. Don't
include a `gs://` prefix or trailing slashes.\n",
- "- `<REPOSITORY_NAME>`: the name of the Google Artifact Registry
repository that you used in the previous step. Don't include the `latest` tag,
because this tag is automatically appended as part of the cell.\n",
+ "- `<REPOSITORY_NAME>`: the name of the Google Artifact Registry
repository that you used in the previous step. \n",
Review Comment:
```suggestion
"- `<REPOSITORY_NAME>`: the name of the Google Artifact Registry
repository that you used in the previous step. \n",
"- `<IMAGE_TAG>`: image tag used in the previous step. Prefer a
versioned tag or SHA instead of :latest tag or mutable tags.\n",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
