sjvanrossum commented on code in PR #33073:
URL: https://github.com/apache/beam/pull/33073#discussion_r1837108783
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java:
##########
@@ -665,6 +665,9 @@ private Map<String, Object> overrideBootstrapServersConfig(
return config;
}
+ // TODO: Collapse the two moving average trackers into a single accumulator
using a single Guava
+ // AtomicDouble. Note that this requires that a single thread will call
update and that while get
+ // may be called by multiple threads the method must only load the
accumulator itself.
Review Comment:
Renamed `numRecords` to `estimatedNumRecords` at the call-site and removed
the method's parameter after trying to keep it as either `maxNumRecords` or
`estimatedNumRecords`. Instead, the method `getGapsFilledWithZeros` omits
scaling by any parameter and leaves that to the caller. This allows the caller
to provide an appropriate name for a potential scaling factor at the call-site
(`currentNumRecords`, `maxNumRecords`, `estimatedNumRecords`,
`expectedNumRecords`, etc.).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
