Abacn commented on code in PR #33059:
URL: https://github.com/apache/beam/pull/33059#discussion_r1837467012
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java:
##########
@@ -567,14 +568,17 @@ static FileSystem getFileSystemInternal(String scheme) {
*
* <p>Outside of workers where Beam FileSystem API is used (e.g. test
methods, user code executed
* during pipeline submission), consider use {@link
#registerFileSystemsOnce} if initialize
- * FIleSystem of supported schema is the main goal.
+ * FileSystem of supported schema is the main goal.
*/
@Internal
public static void setDefaultPipelineOptions(PipelineOptions options) {
checkNotNull(options, "options cannot be null");
long id = options.getOptionsId();
int nextRevision = options.revision();
+ // entry to set other PipelineOption determined flags
+ Metrics.setDefaultPipelineOptions(options);
Review Comment:
setDefaultPipelineOptions will be called once per worker, on SDK harness
startup, so the overloead is minimum
Separate call has much larger diff. Multiple runners has their own main()
function (search for FileSystems.setDefaultPipelineOptions) give a hint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
